Fix label lower case #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
reviewed
Jun 30, 2019
src/main.rs
Outdated
| const COMMENTS: &'static str = "Comments"; | ||
| const FILES: &'static str = "Files"; | ||
| const LINES: &'static str = "Total lines"; | ||
| const CODE: &'static str = "code lines"; |
There was a problem hiding this comment.
I'd prefer if this was lines of code, I know it's different from the rest, but code lines doesn't sound correct to me.
|
Thank you for your PR! I'm sorry that I didn't get to this sooner as there are now merge conflicts. If you could resolve them and address the feedback I've left. I'd be happy to merge this. |
conao3
force-pushed
the
fix-label-lower-case
branch
from
13ededa
to
3bb9568
Compare
|
rebased! |
|
fix |
|
No that's fine. Thank you again for your PR, and congrats on your first contribution! 🎉 |
|
OK. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the label the lower case. See #3.
I do not know about
LoCso please correct it after merging.(Cargo.lock change is a message automatically inserted by cargo.)